fixes for at-view and at-views #20247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hygiene has changed on 0.6, are you sure the bug applies on 0.5? |
|
@tkelman, yes. On 0.5, I get: julia> let Base = nothing, x = [1]
@view x[1]
end
ERROR: type Void has no field view |
|
This seems good to go. How long should we leave it? |
|
I usually prefer edit: analog |
aviatesk
added a commit
that referenced
this pull request
Jan 26, 2024
The modification that expands `@view A[i]` to `true && view(A, i)` appears to go back as far as #20247. However, I'm not entirely sure why this is necessary. Considering that just expanding it to `view(A, i)` still seems to pass the base test suite, I wonder if it might be just better to get rid of that part.
aviatesk
added a commit
that referenced
this pull request
Jan 27, 2024
The modification that expands `@view A[i]` to `true && view(A, i)` appears to go back as far as #20247. However, I'm not entirely sure why this is necessary. Considering that just expanding it to `view(A, i)` still seems to pass the base test suite, I wonder if it might be just better to get rid of that part.
aviatesk
added a commit
that referenced
this pull request
Jan 29, 2024
The modification that expands `@view A[i]` to `true && view(A, i)` appears to go back as far as #20247. However, I'm not entirely sure why this is necessary. Considering that just expanding it to `view(A, i)` still seems to pass the base test suite, I wonder if it might be just better to get rid of that part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several problems in the
@viewand@views(#20164) macros:@viewhad a hygiene bug, because it used the symbolBasein the caller's scope.@view A[1:end]evaluatedAtwice, which is a problem e.g. ifAis an expression with side effects. Similarly for@views.@views x[i] += yevaluatedxanditwice, again a problem.@views x[i[j]] = ydid not usemaybeviewfori[j]The
@viewfixes (the first commit) should probably be backported to 0.5.(I used a workaround for #20241 here: just escaping the whole expression, with interpolated values as needed so that symbols are evaluated in the correct scope.)